Correctly handling download_database_on_pipeline_creation within a pipeline processor within a default or final pipeline #131236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peline processor within a default or final pipeline
masseyke
added
>bug
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @masseyke, I've created a changelog YAML for you. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…thub.com:masseyke/elasticsearch into fix/geoip-download_database_on_pipeline_creation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where GeoIP databases were not being downloaded when download_database_on_pipeline_creation is set to false but the GeoIP processor is referenced through nested pipeline processors within default or final pipelines. The fix ensures proper recursive traversal of pipeline processors to detect GeoIP processors at any nesting level.
Key changes:
- Enhanced GeoIP processor detection to recursively traverse pipeline processors
- Added cycle detection to prevent stack overflow in pipelines with circular references
- Comprehensive test coverage for nested pipeline scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| GeoIpDownloaderTaskExecutor.java | Core logic enhancement to recursively detect GeoIP processors in nested pipeline processors with cycle detection |
| GeoIpDownloaderTaskExecutorTests.java | New test cases covering nested pipeline scenarios and recursive pipeline detection |
| docs/changelog/131236.yaml | Changelog entry documenting the bug fix |
...s/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloaderTaskExecutor.java
Outdated
Show resolved
Hide resolved
...s/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloaderTaskExecutor.java
Show resolved
Hide resolved
joegallo
reviewed
Jul 18, 2025
| * this could lead to a geo database not being downloaded for the pipeline, but it doesn't really matter since the | ||
| * pipeline was going to fail anyway. | ||
| */ | ||
| logger.warn("Detected that pipeline [{}] is called recursively.", pipelineName); |
There was a problem hiding this comment.
This ends up being too verbose in practice, so I think the logging has to go.
joegallo
approved these changes
Jul 18, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 21, 2025
…peline processor within a default or final pipeline (elastic#131236)
joegallo
pushed a commit
to joegallo/elasticsearch
that referenced
this pull request
Jul 21, 2025
…peline processor within a default or final pipeline (elastic#131236)
|
I've got the 9.0 backport in as #131649, and I've got that one set to (hopefully) automatically backport to 8.19 and 8.18. If it doesn't merge back cleanly, then I'll do more manual backporting. 🤷 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 21, 2025
…peline processor within a default or final pipeline (#131236) (#131649) Co-authored-by: Keith Massey <[email protected]>
This was referenced Jul 21, 2025
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jul 21, 2025
…peline processor within a default or final pipeline (elastic#131236) (elastic#131649) Co-authored-by: Keith Massey <[email protected]>
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jul 22, 2025
…king * upstream/main: (100 commits) Term vector API on stateless search nodes (elastic#129902) TEST Fix ThreadPoolMergeSchedulerStressTestIT testMergingFallsBehindAndThenCatchesUp (elastic#131636) Add inference.put_custom rest-api-spec (elastic#131660) ESQL: Fewer serverless docs in tests (elastic#131651) Skip search on indices with INDEX_REFRESH_BLOCK (elastic#129132) Mute org.elasticsearch.indices.cluster.RemoteSearchForceConnectTimeoutIT testTimeoutSetting elastic#131656 [jdk] Resolve EA OpenJDK builds to our JDK archive (elastic#131237) Add optimized path for intermediate values aggregator (elastic#131390) Correctly handling download_database_on_pipeline_creation within a pipeline processor within a default or final pipeline (elastic#131236) Refresh potential lost connections at query start for `_search` (elastic#130463) Add template_id to patterned-text type (elastic#131401) Integrate LIKE/RLIKE LIST with ReplaceStringCasingWithInsensitiveRegexMatch rule (elastic#131531) [ES|QL] Add doc for the COMPLETION command (elastic#131010) ESQL: Add times to topn status (elastic#131555) ESQL: Add asynchronous pre-optimization step for logical plan (elastic#131440) ES|QL: Improve generative tests for FORK [130015] (elastic#131206) Update index mapping update privileges (elastic#130894) ESQL: Added Sample operator NamedWritable to plugin (elastic#131541) update `kibana_system` to grant it access to `.chat-*` system index (elastic#131419) Clarify heap size configuration (elastic#131607) ...
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jul 22, 2025
…-tracking * upstream/main: (44 commits) Term vector API on stateless search nodes (elastic#129902) TEST Fix ThreadPoolMergeSchedulerStressTestIT testMergingFallsBehindAndThenCatchesUp (elastic#131636) Add inference.put_custom rest-api-spec (elastic#131660) ESQL: Fewer serverless docs in tests (elastic#131651) Skip search on indices with INDEX_REFRESH_BLOCK (elastic#129132) Mute org.elasticsearch.indices.cluster.RemoteSearchForceConnectTimeoutIT testTimeoutSetting elastic#131656 [jdk] Resolve EA OpenJDK builds to our JDK archive (elastic#131237) Add optimized path for intermediate values aggregator (elastic#131390) Correctly handling download_database_on_pipeline_creation within a pipeline processor within a default or final pipeline (elastic#131236) Refresh potential lost connections at query start for `_search` (elastic#130463) Add template_id to patterned-text type (elastic#131401) Integrate LIKE/RLIKE LIST with ReplaceStringCasingWithInsensitiveRegexMatch rule (elastic#131531) [ES|QL] Add doc for the COMPLETION command (elastic#131010) ESQL: Add times to topn status (elastic#131555) ESQL: Add asynchronous pre-optimization step for logical plan (elastic#131440) ES|QL: Improve generative tests for FORK [130015] (elastic#131206) Update index mapping update privileges (elastic#130894) ESQL: Added Sample operator NamedWritable to plugin (elastic#131541) update `kibana_system` to grant it access to `.chat-*` system index (elastic#131419) Clarify heap size configuration (elastic#131607) ...
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jul 22, 2025
…peline processor within a default or final pipeline (elastic#131236) (elastic#131649) Co-authored-by: Keith Massey <[email protected]>
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jul 22, 2025
…peline processor within a default or final pipeline (elastic#131236) (elastic#131649) Co-authored-by: Keith Massey <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
…peline processor within a default or final pipeline (#131236) (#131649) (#131654) Co-authored-by: Keith Massey <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
…peline processor within a default or final pipeline (#131236) (#131649) (#131653) Co-authored-by: Keith Massey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are supposed to load a geoip database even if
download_database_on_pipeline_creationis set to false, if it is referenced from a default or final processor. However, if the geoip processor is referenced from a pipeline that is referenced as a pipeline processor from the default or final pipeline, we do not correctly do this. The result is that the database is not downloaded, and all data is tagged with something like_geoip_database_unavailable_GeoLite2-City.mmdbrather than having geo data added to it.Related: #96624